Fixes example service name example consistency#1358
Conversation
ghost
left a comment
There was a problem hiding this comment.
Looks like a useful change to me, in the context of the uses in the other parts of the file
|
One minor thing I'm just noticing: the service class is named |
|
Thanks for the review. Actually the option is service = 'myservice' # comes from the `--service` param
f'Service{service.title()}' # then the dynamic class is the following -> ServiceMyserviceNot sure if it's clear? |
|
Ah. I think I was confused because I misread the text, I kind of thought I should specify Previously:
Suggestion:
But of course that's kind of unrelated to the change in the pull request, which is definitely an improvement in any case |
It makes it easier to understand by using the initial example with `myservice` as service name.
d4d7017 to
59b0061
Compare
|
Thank you @Jonast I've adopted your suggestion 🍻 |
It makes it easier to understand by using the initial example with
myserviceas service name.